Re: WARN in do_rt_tgsigqueueinfo()

From: Oleg Nesterov
Date: Thu May 15 2014 - 14:05:04 EST


On 05/15, Mateusz Guzik wrote:
>
> On Thu, May 15, 2014 at 11:54:15AM -0400, Dave Jones wrote:
> >
> > I'm of the opinion that a user-triggerable WARN is a bug, but aparently
> > not everyone else feels that way.

I didn't really like this WARN_ONCE() when I looked at the patch which
added it, but I didn't try to argue.

> imho warning sysadmins about userspace using deprecated stuff is fine as
> long as users are not able to spam the console with it.

Agreed,

> Warning reported here just looks scary and provides no information for
> sysadmins so I guess it hould be changed.

Again, agreed.

So imo we should either remove it, ot turn it into

pr_warn_once("something meaningful");

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/