Re: [PATCH 2/6] sched/fair.c: change "has_capacity" to "has_free_capacity"

From: Vincent Guittot
Date: Thu May 15 2014 - 03:28:29 EST


On 15 May 2014 09:21, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Wed, May 14, 2014 at 04:57:06PM -0400, Nicolas Pitre wrote:
>> The capacity of a CPU/group should be some intrinsic value that doesn't
>> change with task placement. It is like a container which capacity is
>> stable regardless of the amount of liquid in it... unless the container
>> itself is crushed that is, but that's another story.
>>
>> Therefore let's rename "has_capacity" to "has_free_capacity" in order to
>> better convey the wanted meaning.
>>
>
> Yeah, not really, the whole capacity thing is bollocks, but sure we can
> rename it for as long as it still lives ;-)

Hi,

Yes, I'm preparing an update of my rework around cpu_power and this
field will disappear

Vincent
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/