Re: [PATCH V2] fs/reiserfs/stree.c: remove obsolete __constant

From: Jan Kara
Date: Wed May 14 2014 - 18:01:51 EST


On Sat 03-05-14 22:33:24, Fabian Frederick wrote:
> __constant_cpu_to_le32 converted to cpu_to_le32
>
> Cc: reiserfs-devel@xxxxxxxxxxxxxxx
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
Just for my education, where have you learned that __constant_...
functions are obsolete?

Honza
> ---
> V2: Cc email fixed
>
> fs/reiserfs/stree.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index b14706a..615cd9a 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -228,10 +228,10 @@ const struct reiserfs_key MIN_KEY = { 0, 0, {{0, 0},} };
>
> /* Maximal possible key. It is never in the tree. */
> static const struct reiserfs_key MAX_KEY = {
> - __constant_cpu_to_le32(0xffffffff),
> - __constant_cpu_to_le32(0xffffffff),
> - {{__constant_cpu_to_le32(0xffffffff),
> - __constant_cpu_to_le32(0xffffffff)},}
> + cpu_to_le32(0xffffffff),
> + cpu_to_le32(0xffffffff),
> + {{cpu_to_le32(0xffffffff),
> + cpu_to_le32(0xffffffff)},}
> };
>
> /* Get delimiting key of the buffer by looking for it in the buffers in the path, starting from the bottom
> --
> 1.8.4.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/