Re: [PATCH] lib/crc7: Shift crc7() output left 1 bit

[Pavel Machek]

On Sun 2014-05-11 05:16:07, George Spelvin wrote:
> > Looks good, but should not function name change when functionality got
> > completely different?
> 
> I couldn't think of one.  Can you?
> 
> I suppose adding a _be (big-endian) suffix would be consistent.
> Is that okay with you?
> 
> To do it properly, I have to rename all of:
> 
> crc7_syndrome_table[]
> crc7_byte()
> crc7()
> 
> even though the third is the only (in-tree) user of the first two.

If the first two are static, there's no problem.

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/