Re: [PATCH v4 2/8] OF: Introduce DT overlay support.

[Guenter Roeck]

On 05/14/2014 06:03 AM, Geert Uytterhoeven wrote:
> On Wed, May 14, 2014 at 12:08 PM, Grant Likely
> <grant.likely@xxxxxxxxxxxx> wrote:
> > > +config OF_OVERLAY
> > > +     bool "OF overlay support"
> > > +     depends on OF
> > > +     select OF_DYNAMIC
> > > +     select OF_DEVICE
> > > +     select OF_RESOLVE
> > > +     help
> > > +       OpenFirmware overlay support. Allows you to modify on runtime the
> > > +       live tree using overlays.
> >
> > Should not be a user-visable option. Drivers using it should select it
>
> Why not? It's up to the (final) user to use it, or not.
>
> > or otherwise cause it to be enabled.
>
> Why should this be driver-specific? Shouldn't this just work with all drivers?

It does once enabled.

I think what Grant refers to is that there has to be a driver which implements
the actual overlay insertion and removal (ie calls the new API functions),
and that the Kconfig option for this driver should select OF_OVERLAY
instead of depending on it.

Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/