Re: [PATCH 4/4] spi: qup: Add support for v1.1.1

From: Andy Gross
Date: Tue May 13 2014 - 18:20:35 EST


On Tue, May 13, 2014 at 03:08:45PM -0700, Stephen Boyd wrote:
> On 05/13, Andy Gross wrote:
> > @@ -488,7 +491,7 @@ static int spi_qup_probe(struct platform_device *pdev)
> > struct resource *res;
> > struct device *dev;
> > void __iomem *base;
> > - u32 data, max_freq, iomode;
> > + u32 data = 0, max_freq, iomode;
>
> It looks like data is unused? But actually it's used to print a
> version out and now it will always print version 0. Perhaps that
> printk needs an update?

ACK! I thought I killed that. I'll fix that.

--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/