Re: [patch] net, filter: make new test_bpf depend on networking

From: Alexei Starovoitov
Date: Tue May 13 2014 - 16:07:53 EST


On Tue, May 13, 2014 at 12:57 PM, David Rientjes <rientjes@xxxxxxxxxx> wrote:
> CONFIG_TEST_BPF depends on CONFIG_NET, otherwise the build fails:
>
> ERROR: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> ERROR: "kfree_skb" [lib/test_bpf.ko] undefined!
> ERROR: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> ERROR: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> ERROR: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Add the dependency.
>
> Cc: Alexei Starovoitov <ast@xxxxxxxxxxxx>
> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>

commit 98920ba6911c7 ("net: fix test_bpf build to depend on NET")
is already in net-next.
Sorry about the breakage.

> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1639,6 +1639,7 @@ config TEST_USER_COPY
> config TEST_BPF
> tristate "Test BPF filter functionality"
> default n
> + depends on NET
> depends on m
> help
> This builds the "test_bpf" module that runs various test vectors
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/