Re: [PATCH v1 07/11] mmc: mmci: move ST specific register extensions access under condition.

[Srinivas Kandagatla]

On 13/05/14 09:08, Linus Walleij wrote:
> > >         /* Keep ST Micro busy mode if enabled */
> > >-       datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE;
> > >+       if (host->hw_designer == AMBA_VENDOR_ST)
> > >+               datactrl |= host->datactrl_reg & MCI_ST_DPSM_BUSYMODE;
> Do not hard-check the hw_designer everywhere, follow the pattern
> if storing special stuff in the variant data.
Got it, I will fix this across other patches too.

> struct variant_data {
>          u32 datactrl_mask_busymode;
> (...)
>
> static struct variant_data variant_u300 = {
>          .datactrl_mask_busymode = MCI_ST_DPSM_BUSYMODE,
> (...)
> static struct variant_data variant_nomadik = {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/