Re: [PATCH] e1000: To filter the negative skb->len

From: Eric Dumazet
Date: Tue May 13 2014 - 00:04:31 EST


On Tue, 2014-05-13 at 11:33 +0800, xuyongjiande@xxxxxxxxx wrote:
> From: Yongjian Xu <xuyongjiande@xxxxxxxxx>
>
> skb->len is unsigned int, "skb->len <= 0" should be "(int)(skb->len) <= 0".

Why ?

Did you hit a case skb->len would be 0 or 'negative' ?

This test makes no sense, just remove it.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/