Re: [PATCH 3/5] nfsd: Only set PF_LESS_THROTTLE when really needed.

From: NeilBrown
Date: Sun May 11 2014 - 21:06:13 EST


On Tue, 6 May 2014 16:54:18 -0400 "J. Bruce Fields" <bfields@xxxxxxxxxxxx>
wrote:

> On Wed, Apr 23, 2014 at 12:40:58PM +1000, NeilBrown wrote:
> > PF_LESS_THROTTLE has a very specific use case: to avoid deadlocks
> > and live-locks while writing to the page cache in a loop-back
> > NFS mount situation.
> >
> > It therefore makes sense to *only* set PF_LESS_THROTTLE in this
> > situation.
> > We now know when a request came from the local-host so it could be a
> > loop-back mount. We already know when we are handling write requests,
> > and when we are doing anything else.
> >
> > So combine those two to allow nfsd to still be throttled (like any
> > other process) in every situation except when it is known to be
> > problematic.
>
> Looks simple enough, ACK.--b.
>

Thanks.
I'll resend the bits need for just this.

The NFS side need to wait for wait_on_bit improvements which seem to be on a
slow path at the moment.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature