Re: [PATCH 2/2] sched: Fix next_balance logic in rebalance_domains() and idle_balance()

From: Jason Low
Date: Fri May 09 2014 - 13:29:10 EST


On Fri, 2014-05-09 at 11:08 +0200, Peter Zijlstra wrote:
> On Thu, May 08, 2014 at 05:49:22PM -0700, Jason Low wrote:
> > On Thu, 2014-05-08 at 15:14 -0700, Jason Low wrote:
> > > Hi Ingo, Peter,
> > >
> > > Were there NULL domains on the test system? If so, I think we can
> > > address the problem by doing update_next_balance() only if the below
> > > rcu_dereference_check_sched_domain() returns a non-null domain.
> >
> > Also, below is a patch which has the change:
> >
>
> Thanks, and yes, NULL domains are a perfectly normal thing to have
> (though not common on normal boot paths).

Okay. Likewise, on my test machine, I offline all but 1 CPU
in order to try reproducing the issue.

Thanks,
Jason

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/