Re: [PATCH 2/4] sched,numa: weigh nearby nodes for task placement on complex NUMA topologies
From: Rik van Riel
Date: Fri May 09 2014 - 11:07:07 EST
On 05/09/2014 06:13 AM, Peter Zijlstra wrote:
On Thu, May 08, 2014 at 01:23:29PM -0400, riel@xxxxxxxxxx wrote:
This patch does nothing on machines with simple NUMA topologies.
Was this:
+ /*
+ * No need to calculate a score if the system has a simple NUMA
+ * topology, with no node distances between "local" and "far away".
+ */
+ if (max_distance == LOCAL_DISTANCE)
+ return 0;
Supposed to make that true?
It doesn't. That test is a !numa test, not a fully connected test.
Look at patch 1/4. I only set max_distance to !LOCAL_DISTANCE
if the system has multiple different distances in the SLIT
table.
I guess that needs to be cleaned up :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/