Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req"

[micky]

Hi Lee

Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: 
add support for pre_reqand post_req"
if need for 3.15 fix.

Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
> On 29 April 2014 03:54,<micky_ching@xxxxxxxxxxxxxx>  wrote:
> > >From: Micky Ching<micky_ching@xxxxxxxxxxxxxx>
> > >
> > >This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
> > >
> > >commit <mmc: rtsx: add support for pre_req and post_req> did use
> > >mutex_unlock() in tasklet, but mutex_unlock() can't used in
> > >tasklet(atomic context). The driver need use mutex to avoid concurrency,
> > >so we can't use tasklet here, the patch need to be removed.
> > >
> > >The spinlock host->lock and pcr->lock may deadlock, one way to solve the
> > >deadlock is remove host->lock in sd_isr_done_transfer(), but if using
> > >workqueue the we can avoid using the spinlock and also avoid the problem.
> > >
> > >Signed-off-by: Micky Ching<micky_ching@xxxxxxxxxxxxxx>
> Acked-by: Ulf Hansson<ulf.hansson@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/