Re: [PATCH] rtlwifi: rtl8188ee: initialize packet_beacon

From: John W. Linville
Date: Tue Apr 22 2014 - 14:01:06 EST


On Mon, Apr 21, 2014 at 12:15:44PM -0500, Larry Finger wrote:
> On 04/21/2014 11:38 AM, Colin King wrote:
> >From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >
> >static code analysis from cppcheck reports:
> >
> >[drivers/net/wireless/rtlwifi/rtl8188ee/trx.c:322]:
> > (error) Uninitialized variable: packet_beacon
> >
> >packet_beacon is not initialized and hence packet_beacon
> >contains garbage from the stack, so set it to false.
> >
> >Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> >---
> > drivers/net/wireless/rtlwifi/rtl8188ee/trx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This change should have a "Cc: Stable <stable@xxxxxxxxxxxxxxx> [3.10+] notation.
>
> Other than that, Acked-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>
> John: Is it possible for you to add stable, or do you want Colin to resubmit.

Got it, thanks...

--
John W. Linville Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx might be all we have. Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/