Re: [PATCH] Export irq tracepoints for use by kernel modules

From: Josh Boyer
Date: Tue Apr 22 2014 - 11:01:17 EST


On Tue, Apr 22, 2014 at 10:26 AM, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Tue, Apr 22, 2014 at 07:24:20AM -0700, Drew Richardson wrote:
>> After commit de7b2973903c6cc50b31ee5682a69b2219b9919d ("tracepoint:
>> Use struct pointer instead of name hash for reg/unreg tracepoints"),
>> any tracepoints used in a kernel module must be exported.
>
> How does this matter given that there aren't any modular users?

We had a bug report about this breaking systemtap type usage[1]. In
there, Matthieu suggested that the new for_each_kernel_tracepoint
interface be used.

Drew, it would have been proper to CC the author of the change you're
referencing on all of your patches to export these symbols.

josh

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1087623
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/