Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

From: Dan Carpenter
Date: Tue Apr 22 2014 - 06:11:36 EST


On Sun, Apr 20, 2014 at 02:17:11PM +0530, navin patidar wrote:
> _ReadLEDSetting() doesn't read led settings this function actually
> initialize member variables of struct led_priv, we should do that
> inside rtl8188eu_InitSwLeds().
>

This seems like a bugfix or is it just a cleanup? It's not clear to me
from the patch description. Have you tested this patch?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/