Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl definition

[Dan Carpenter]

I like the idea of this patch but the v2 version still doesn't compile.
I don't understand how you can write such a nice patch and not even test
that it compiles.  Twice.  That's not ok.

On Sun, Apr 20, 2014 at 06:05:38PM +0000, Son P. Nguyen wrote:
> From: "Son P. Nguyen" <fastmutex@xxxxxxxxx>

Don't include this when you are sending your own patch.

> 
> Fixed dgnc_pci_tbl definition for correct coding style

This description is not enough.

> 
> PS: This is for task 10 of eudyptula-challenge.

Don't include this line.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/