Re: [PATCH RFC 06/12] mmc: mmci: Add write delay to variant structure.

From: Srinivas Kandagatla
Date: Tue Apr 22 2014 - 04:15:54 EST


Thanks Felipe,

On 21/04/14 23:08, Felipe Balbi wrote:
+ if (var->reg_write_delay && host->mclk)
>+ udelay(1 + ((var->reg_write_delay * USEC_PER_SEC)/host->mclk));
looks like this should be quirk flag instead of a write delay... No
strong feelings though, but it looks like the following would be better,
perhaps:

if (host_is_qualcom(host))
udelay(1 + ((3 * USEC_PER_SEC)/host->mclk));
Am ok with your proposal. I was wondering if someone else might need it in future.
If not I could change it as you suggested.

Thanks,
srini

--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/