Re: [PATCH] FMC: misc_register should not be called while atomic

From: Alessandro Rubini
Date: Wed Apr 16 2014 - 18:40:00 EST


>> --- a/drivers/fmc/fmc-chardev.c
>> +++ b/drivers/fmc/fmc-chardev.c
>> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
>> fc->misc.fops = &fc_fops;
>> fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
>>
>> - spin_lock(&fc_lock);
>> ret = misc_register(&fc->misc);
>> + spin_lock(&fc_lock);
>> if (ret < 0) {
>> kfree(fc->misc.name);
>> kfree(fc);
>> --
>> 1.9.1

This is already applied, though in a slightly different way. Commit
783c2fb1b. I fixed it in Jul 13 2013 after user reports.

"git tag --contains 783c2fb1b" reports v3.12-rc1 and later

/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/