Re: [PATCH] gpio: ich: set regs and reglen for i3100 and ich6 chipset

From: Eric Paris
Date: Tue Apr 15 2014 - 10:44:09 EST


On Tue, 2014-04-15 at 14:21 +0200, Vincent Donnefort wrote:
> From: Vincent Donnefort <vdonnefort@xxxxxxxxx>
>
> This patch fixes kernel NULL pointer BUG introduced by the following commit:
> b667cf488aa9476b0ab64acd91f2a96f188cfd21
> gpio: ich: Add support for multiple register addresses.
>
> Signed-off-by: Vincent Donnefort <vdonnefort@xxxxxxxxx>

Things seem much happier now! Thank you sir!

Tested-by: Eric Paris <eparis@xxxxxxxxxx>

>
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index e73c675..7030422 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -305,6 +305,8 @@ static struct ichx_desc ich6_desc = {
>
> .ngpio = 50,
> .have_blink = true,
> + .regs = ichx_regs,
> + .reglen = ichx_reglen,
> };
>
> /* Intel 3100 */
> @@ -324,6 +326,8 @@ static struct ichx_desc i3100_desc = {
> .uses_gpe0 = true,
>
> .ngpio = 50,
> + .regs = ichx_regs,
> + .reglen = ichx_reglen,
> };
>
> /* ICH7 and ICH8-based */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/