Re: [PATCH 2/2] ARM: dts: berlin: add GPIO nodes for the BG2Q

[Sebastian Hesselbarth]

On 04/15/2014 01:48 PM, Alexandre Belloni wrote:
> On 15/04/2014 at 12:26:11 +0200, Sebastian Hesselbarth wrote :
> > On 04/15/2014 12:00 PM, Jisheng Zhang wrote:
> > > On Tue, 15 Apr 2014 02:23:03 -0700
> > > Sebastian Hesselbarth <sebastian.hesselbarth@xxxxxxxxx> wrote:
> > > > I am fine with using nr-gpios property now, but I guess BG2Q also
> > > > has that CONFIG[1,2] registers to actually read out the features
> > > > synthesized in? If I find some time, I'll prepare a patch for
> > > > dw-apb-gpio to exploit that (optional) information instead of
> > > > using nr-gpios.
> > >
> > > The problem is CONFIG1/2 registers don't exist on some versions.
> > > For example, the version used in BG2/BG2CD. So nr-gpio is necessary
> > > if we want to support these versions.
> >
> > Hmm, are you sure about BG2? I remember reading it and it contains
> > sane values. Anyway, a proper patch for dw-apb-gpio would include
> > checking for sane (e.g. non-zero) values. And nr-gpios will always
> > stay as fall-back just because e.g. sunxi does not have the CONFIG
> > registers.
>
> Shouldn't that be use nr-gpios and if not available, read the CONFIG
> registers? Else, what about bogus registers ?

Probably, it is a better idea to only look for CONFIG registers if
nr-gpios is not set. Anyway, I'll really have to find more time first ;)

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/