Re: [PATCH 1/5] ASoC: omap: rx51: Use devm_snd_soc_register_card

From: Mark Brown
Date: Tue Apr 15 2014 - 08:21:24 EST


On Sat, Apr 05, 2014 at 11:35:49PM +0200, Sebastian Reichel wrote:
> From: Pali Rohár <pali.rohar@xxxxxxxxx>
>
> This patch converts the rx51 ASoC module to use
> devm_snd_soc_register_card. It also adds module alias
> to support driver autoloading.

This doesn't apply against current code and since it does multiple
things it should be multiple patches.

> +static int rx51_soc_remove(struct platform_device *pdev)
> {
> + struct snd_soc_card *card = platform_get_drvdata(pdev);
> +
> snd_soc_jack_free_gpios(&rx51_av_jack, ARRAY_SIZE(rx51_av_jack_gpios),
> rx51_av_jack_gpios);
>
> - platform_device_unregister(rx51_snd_device);
> + card->dev = NULL;
> +

Why is this assignment being done?

Attachment: signature.asc
Description: Digital signature