Re: [PATCH 00/20] Introduce new cpufreq helper macros

From: Viresh Kumar
Date: Tue Apr 15 2014 - 02:02:03 EST


On 15 April 2014 02:37, Stratos Karafotis <stratosk@xxxxxxxxxxxx> wrote:
> This patch set introduces two freq_table helper macros which
> can be used for iteration over cpufreq_frequency_table and
> makes the necessary changes to cpufreq core and drivers that
> use such an iteration procedure.
>
> The motivation was a usage of common procedure to iterate over
> cpufreq_frequency_table across all drivers and cpufreq core.
>
> This was tested on a x86_64 platform.
> Patches 4-17 compiled successfully but unfortunately I was not
> able to compile test patches 18-20.

Mostly okay, just some Nitpicks..

Please rearrange your patches this way:
- First patch just adds the wrappers
- Second one makes changes to drivers/cpufreq/, i.e. include all core
and drivers
changes into a single patch here as the logs are exactly same.
- Then framework by framework, as we may need Acks/Reviews by them
separately..

So, probably just 5-7 would do.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/