Re: [PATCH v2 1/2] regulator: pbias: Fix is_enabled callback implementation

From: Mark Brown
Date: Mon Apr 14 2014 - 17:17:25 EST


On Sat, Mar 08, 2014 at 11:55:29AM +0800, Axel Lin wrote:
> The is_enabled implementation is wrong in some cases:
> e.g. for pbias_mmc_omap5: enable_mask is : BIT(27) | BIT(25) | BIT(26)
> However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits.
> So is_enabled callback will always return false in this case.
> Fix the logic to compare the register value with info->enable rather than
> info->enable_mask.

Applied both, thanks.

Attachment: signature.asc
Description: Digital signature