Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

[Paul E. McKenney]

On Mon, Apr 14, 2014 at 12:27:47PM -0400, Pranith Kumar wrote:
> On Mon, Apr 14, 2014 at 12:19 PM, Pranith Kumar <pranith@xxxxxxxxxx> wrote:
> > Hi Paul,
> >
> > On Mon, Apr 14, 2014 at 12:07 PM, Paul E. McKenney
> > <paulmck@xxxxxxxxxxxxxxxxxx> wrote:
> >> On Sun, Apr 13, 2014 at 05:53:53PM -0400, Pranith Kumar wrote:
> >>> remove duplicate definition of extern resched_cpu
> >>>
> >>> Signed-off-by: Pranith Kumar <bobby.prani@xxxxxxxxx>
> >>
> >> Hello, Pranith,
> >>
> >> When I apply this patch I get the following:
> >>
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: In function ârcu_implicit_dynticks_qsâ:
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: error: implicit declaration of function âresched_cpuâ [-Werror=implicit-function-declaration]
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c: At top level:
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:1009:13: warning: conflicting types for âresched_cpuâ [enabled by default]
> >> /home/paulmck/public_git/linux-rcu/kernel/rcu/tree.c:895:3: note: previous implicit declaration of âresched_cpuâ was here
> >>
> >> This failed in under number of different Kconfig setups, the .config file
> >> for one of them is attached.
> >>
> >> So this declaration really is needed.  Just out of curiosity, what led
> >> you to believe that it could be removed?
> >>
> 
> Your attached config has the following:
> 
> Linux/x86 3.14.0-rc3 Kernel Configuration
> 
> The patch is against 3.15.0-rc1 (the latest at this time). May be that
> is the reason?

Nope, it was just me messing up when hand-applying the patch.  The reason
the patch wouldn't apply is that I am working against the -rcu tree at
git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git,
branch rcu/dev.  Once I applied it correctly, removing the second of
the two declarations rather than the first one, it worked fine.

So please accept my apologies for my confusion.  I have queued your
patch for 3.16, thank you!

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/