RE: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic appropriately

[KY Srinivasan]

> -----Original Message-----
> From: H. Peter Anvin [mailto:hpa@xxxxxxxxx]
> Sent: Monday, April 14, 2014 10:02 AM
> To: KY Srinivasan; x86@xxxxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx;
> apw@xxxxxxxxxxxxx; jasowang@xxxxxxxxxx; tglx@xxxxxxxxxxxxx;
> JBeulich@xxxxxxxx
> Subject: Re: [PATCH V3 1/1] X86: Probe for PIC and set legacy_pic
> appropriately
> 
> On 04/14/2014 10:46 AM, K. Y. Srinivasan wrote:
> > This patch implements the proposal put forth by H. Peter Anvin
> <hpa@xxxxxxxxxxxxxxx>.
> >
> > In  version V1 of the patch, I had cleaned up the code based on comments
> from Peter.
> > In  version V2 of the patch, I have addressed additional comments from
> Peter.
> > In this version of the patch, I have addressed Jan's comments
> (JBeulich@xxxxxxxx).
> >
> > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> 
> Technically the patch looks good, but I'm going to have to reject it based on
> the patch description.
> 
> Keep in mind that the above description is the only thing that would go into
> the git repository, and needs to be understandable to someone, say,
> 10 years from now.
> 
> The above says nothing about what the proposal was, and the motivation,
> and the problems it addresses.  So the patch is good, but please write a
> proper, standalone description for it.

Thanks Peter; I will update the description and send it out soon.

K. Y
> 
> Thanks,
> 
> 	-hpa
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/