Re: [RFC][PATCH 8/8] sched,idle: Reflow cpuidle_idle_call()

From: Peter Zijlstra
Date: Mon Apr 14 2014 - 04:59:37 EST


On Sun, Apr 13, 2014 at 05:36:46PM -0400, Nicolas Pitre wrote:
> > @@ -102,90 +102,64 @@ static int cpuidle_idle_call(void)
> > * Check if the cpuidle framework is ready, otherwise fallback
> > * to the default arch specific idle method
> > */
> > - ret = cpuidle_enabled(drv, dev);
> > + if (cpuidle_enabled(drv, dev))
> > + goto use_default;
>
> Why not using braces here and moving the use_default code block inside
> it instead?

I didn't because there's two goto use_default sites, but sure, I can do
that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/