Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

From: Pranith Kumar
Date: Sun Apr 13 2014 - 23:32:52 EST


On Sun, Apr 13, 2014 at 11:18 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:

>> As the comment mentions, resched_cpu is internal to the scheduler and
>> hence is in sched/sched.h file and not in linux/sched.h.
>
> Note the use of quotes and lack of angle brackets.
>
>> sched/sched.h cannot be included in other subsystems directly.
>
> If functions from it can be declared extern,
> then likely it could be used in an #include.
>
>

All the users of resched_cpu are in kernel/sched/ and in
kernel/rcu/tree.c. I think the only reason this was declared extern
was for the special use in rcu/tree.c.


--
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/