Re: [PATCH 1/1] kernel/rcu/tree.c: remove duplicate extern definition

From: Pranith Kumar
Date: Sun Apr 13 2014 - 23:04:45 EST


On Sun, Apr 13, 2014 at 10:50 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>>
>> -/*
>> - * This function really isn't for public consumption, but RCU is special in
>> - * that context switches can allow the state machine to make progress.
>> - */
>> -extern void resched_cpu(int cpu);
>
> why not #include "sched.h"
>
> and remove both declarations?
>
>

As the comment mentions, resched_cpu is internal to the scheduler and
hence is in sched/sched.h file and not in linux/sched.h.

sched/sched.h cannot be included in other subsystems directly.

Regards,
--
Pranith
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/