Re: [RFC PATCH 0/2] managed token devres interfaces

From: Shuah Khan
Date: Thu Apr 10 2014 - 10:32:38 EST


On 04/10/2014 05:38 AM, Mauro Carvalho Chehab wrote:
Hi Alan,

Em Thu, 10 Apr 2014 12:04:35 +0100
One Thousand Gnomes <gnomes@xxxxxxxxxxxxxxxxxxx> escreveu:

- Construct string with (dev is struct em28xx *dev)
format: "tuner:%s-%s-%d"
with the following:
dev_name(&dev->udev->dev)
dev->udev->bus->bus_name
dev->tuner_addr

What guarantees this won't get confused by hot plugging and re-use of the
bus slot ?

Good point. Yes, this should be addressed.


This resource should be destroyed when em28xx_ handles unplug from its em28xx_usb_disconnect() or in generic words, in its "uninit". It is a matter of making sure this resource is handled in the "uninit" for this media device/driver(s) like any other shared resource.

Would that cover the hot plugging and re-use of the bus slot scenario?

-- Shuah


--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@xxxxxxxxxxx | (970) 672-0658
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/