Re: [PATCH 21/27] ARM: dts: exynos3250: Add PMU dt data

From: Chanwoo Choi
Date: Thu Apr 10 2014 - 07:20:31 EST


Hi,

On 04/10/2014 07:23 PM, Chanho Park wrote:
> Hi,
>
>> -----Original Message-----
>> From: linux-arm-kernel [mailto:linux-arm-kernel-
>> bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Chanwoo Choi
>> Sent: Thursday, April 10, 2014 7:06 PM
>> To: kgene.kim@xxxxxxxxxxx; t.figa@xxxxxxxxxxx; linux-samsung-
>> soc@xxxxxxxxxxxxxxx
>> Cc: hyunhee.kim@xxxxxxxxxxx; sw0312.kim@xxxxxxxxxxx; linux-
>> kernel@xxxxxxxxxxxxxxx; yj44.cho@xxxxxxxxxxx; inki.dae@xxxxxxxxxxx;
>> cw00.choi@xxxxxxxxxxx; kyungmin.park@xxxxxxxxxxx; linux-arm-
>> kernel@xxxxxxxxxxxxxxxxxxx
>> Subject: [PATCH 21/27] ARM: dts: exynos3250: Add PMU dt data
>>
>> From: Hyunhee Kim <hyunhee.kim@xxxxxxxxxxx>
>>
>> ARM CPU has its own PMU (Performance Monitoring Unit). This patch add
>> PMU dt
>> data to support PMU for CPU. Exynos3250 has four PMU interrupts.
>>
>> Signed-off-by: Hyunhee Kim <hyunhee.kim@xxxxxxxxxxx>
>> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx>
>> ---
>> arch/arm/boot/dts/exynos3250.dtsi | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos3250.dtsi
>> b/arch/arm/boot/dts/exynos3250.dtsi
>> index ceed761..2f0ca32 100644
>> --- a/arch/arm/boot/dts/exynos3250.dtsi
>> +++ b/arch/arm/boot/dts/exynos3250.dtsi
>> @@ -280,4 +280,9 @@
>> pinctrl-0 = <&i2c7_bus>;
>> status = "disabled";
>> };
>> +
>> + pmu {
>> + compatible = "arm,cortex-a7-pmu";
>> + interrupts = <0 18 0>, <0 19 0>, <0 20 0>, <0 21 0>;
>> + };
>
> As I know, the exynos3250 has two CPU cores. Why does it have four pmu
> interrupts?
> IMO it is sufficient it has only two interrupts.

OK, I'll fix it using only two interrupt for dual-core.

Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/