Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum issues

From: David Miller
Date: Wed Apr 09 2014 - 14:42:23 EST


From: KY Srinivasan <kys@xxxxxxxxxxxxx>
Date: Wed, 9 Apr 2014 18:39:57 +0000

>
>
>> -----Original Message-----
>> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
>> Sent: Wednesday, April 9, 2014 11:37 AM
>> To: KY Srinivasan
>> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
>> devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; apw@xxxxxxxxxxxxx;
>> jasowang@xxxxxxxxxx
>> Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum
>> issues
>>
>> From: KY Srinivasan <kys@xxxxxxxxxxxxx>
>> Date: Wed, 9 Apr 2014 18:08:47 +0000
>>
>> > Thanks Dave. I will COW the SKB before changing the checksum value. I
>> > do have a question though. I looked at a bunch of hardware drivers
>> > and they modify the header information, specially checksum field and I
>> > could not see where they had COWed the skb. I was grepping for skb_cow
>> > in these drivers.
>>
>> Look for skb_cow_head(), for example, the tg3.c driver uses this.
>>
> Thank you. I will update this patch. Do you want me to resend the whole set or just
> this patch.

You never need to ask me this.

Always, when there is an update to any part of a series, re-submit the entire
series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/