Re: [PATCH v2] ARM: msm: Make MSM_HAS_DEBUG_UART_HS option visible to multiplatform targets

From: Stephen Boyd
Date: Wed Apr 09 2014 - 13:44:54 EST


On 04/09/14 07:26, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@xxxxxxxxxx>
>
> High Speed UART is available also in new multiplatform QCOM targets.
>
> This fixes:
>
> scripts/kconfig/conf --silentoldconfig Kconfig
> warning: (DEBUG_MSM8660_UART && DEBUG_MSM8960_UART && DEBUG_MSM8974_UART) selects MSM_HAS_DEBUG_UART_HS which has unmet direct dependencies (ARCH_MSM)
> warning: (DEBUG_MSM8660_UART && DEBUG_MSM8960_UART && DEBUG_MSM8974_UART) selects MSM_HAS_DEBUG_UART_HS which has unmet direct dependencies (ARCH_MSM)
>
> Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>

It might be better to move the config out of mach-msm into
arch/arm/Kconfig.debug. I think the eventual goal is to remove all these
#defines for the physical/virtual address and have users enter the
addresses in Kconfig similar to how Russell has done for the pl01X. If
that happens then we end up with a DEBUG_MSM_UART (for 7201,8x50, 7x30)
and DEBUG_QCOM_UARTDM for all others and the help text would indicate
which addresses to use.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/