Re: [PATCH 3/5] hung_task: Convert process iteration to use for_each_process_thread()

From: Oleg Nesterov
Date: Wed Apr 09 2014 - 13:23:16 EST


On 04/09, Frederic Weisbecker wrote:
>
> @@ -167,18 +167,18 @@ static void check_hung_uninterruptible_tasks(unsigned long timeout)
> return;
>
> rcu_read_lock();
> - do_each_thread(g, t) {
> + for_each_process_thread(p, t) {
> if (!max_count--)
> goto unlock;
> if (!--batch_count) {
> batch_count = HUNG_TASK_BATCHING;
> - if (!rcu_lock_break(g, t))
> + if (!rcu_lock_break(p, t))

Not sure. And in any case this is suboptimal. Frederic, I'll write
another email tomorrow. In fact I already have the patch which changes
check_hung_uninterruptible_tasks() somewhere.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/