Re: [PATCH 2/2] checkpatch: skip directories in file checking mode

[Joe Perches]

On Tue, 2014-04-08 at 08:25 -0500, Rob Herring wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
> 
> Running checkpatch.pl on a list of files using a wildcard will exit if
> a directory is encountered. For example:
> 
> $ scripts/checkpatch.pl -f arch/*
> diff: arch/alpha/null: No such file or directory
> 
> The correct operation is arch/Kconfig should be checked. Fix this by
> skipping files which are not regular files.

<shrug>

You could make the same argument that it should
skip .o files if you fed it to checkpatch on the
command line.

I think the correct thing is to feed only files
you want scanned to checkpatch.

git ls-files arch/ | xargs ./scripts/checkpatch.pl -f



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/