Re: [PATCH 2/2] ARM: dts: MSM8974: Add pinctrl node

From: Ivan T. Ivanov
Date: Tue Apr 08 2014 - 08:15:56 EST



Hi,

On Mon, 2014-04-07 at 18:53 -0500, Timur Tabi wrote:
> On Thu, Feb 6, 2014 at 9:28 AM, Ivan T. Ivanov <iivanov@xxxxxxxxxx> wrote:
> > + spi8_default: spi8_default {
> > + mosi {
> > + pins = "gpio45";
> > + function = "blsp_spi8";
> > + };
> > + miso {
> > + pins = "gpio46";
> > + function = "blsp_spi8";
> > + };
> > + cs {
> > + pins = "gpio47";
> > + function = "blsp_spi8";
> > + };
> > + clk {
> > + pins = "gpio48";
> > + function = "blsp_spi8";
> > + };
>
> I'm confused by this. Isn't this information already defined in the
> pinctrl-msm8x74.c driver?
>
> static const char * const blsp_spi8_groups[] = {
> "gpio45", "gpio46", "gpio47", "gpio48"
> };

I am not sure that I understand the question. This is one of
possible ways to describe relationship between pins and functions.
As they are described is visible what is their real purpose.

Regards,
Ivan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/