Re: [PATCH] driver core: Move driver_data back to struct device

From: Greg Kroah-Hartman
Date: Mon Apr 07 2014 - 16:55:55 EST


On Mon, Apr 07, 2014 at 10:53:22AM +0200, Jean Delvare wrote:
> Having to allocate memory as part of dev_set_drvdata() is a problem
> because that memory may never get freed if the device itself is not
> created. So move driver_data back to struct device.
>
> This is a partial revert of commit b4028437.
>
> Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> ---
> Greg, we discussed that back in January (in a thread named "Freeing of
> dev->p") but I did not hear back from you and I can't see this fix in
> your driver-core tree.

Thanks for doing this, I'll queue this up after -rc1 is out. I still
have that thread in my TODO list, unfortunatly, higher-priority items
keep bumping it down :(

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/