Re: [PATCH v2 1/1] staging: comedi: Fix checkpatch warning

From: Greg Kroah-Hartman
Date: Sat Apr 05 2014 - 18:07:21 EST


On Fri, Apr 04, 2014 at 10:55:18PM +0200, Camille Begue wrote:
> Wrap lines > 80 columns.
> This patch is part of eudyptula challenge
>
> Signed-off-by: Camille Begue <camille.begue44@xxxxxxxxx>
> ---
> drivers/staging/comedi/comedi_fops.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> index ea6dc36..0f05e87 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -1435,13 +1435,16 @@ static int __comedi_get_user_cmd(struct comedi_device *dev,
> s = &dev->subdevices[cmd->subdev];
>
> if (s->type == COMEDI_SUBD_UNUSED) {
> - dev_dbg(dev->class_dev, "%d not valid subdevice\n", cmd->subdev);
> + dev_dbg(dev->class_dev,
> + "%d not valid subdevice\n",
> + cmd->subdev);

Why did you split this into 3 lines, it only needs to be 2 like this:
dev_dbg(dev->class_dev, "%d not valid subdevice\n",
cmd->subdev);

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/