Re: [PATCH 3/4] perf, callchain: Add generic report parse callchain callback function

[Don Zickus]

On Thu, Apr 03, 2014 at 02:57:32PM +0900, Namhyung Kim wrote:
> On Mon, 24 Mar 2014 15:32:56 -0400, Don Zickus wrote:
> > This takes the parse_callchain_opt function and copies it into the
> > callchain.c file.  Now the c2c tool can use it too without duplicating.
> >
> > Signed-off-by: Don Zickus <dzickus@xxxxxxxxxx>
> > ---
> >  tools/perf/util/callchain.c | 83 +++++++++++++++++++++++++++++++++++++++++++++
> >  tools/perf/util/callchain.h |  1 +
> >  2 files changed, 84 insertions(+)
> >
> > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> > index 8d9db45..2320678 100644
> > --- a/tools/perf/util/callchain.c
> > +++ b/tools/perf/util/callchain.c
> > @@ -25,6 +25,89 @@
> >  
> >  __thread struct callchain_cursor callchain_cursor;
> >  
> > +int
> > +report_parse_callchain_opt(const char *arg)
> 
> As it eliminated any dependency to the report code, the name can omit
> 'report' as well.

Hmm, shrinking this down to 'parse_callchain_opt' seems to conflict with
builtin-top.c's defintion which is a wrapper around
record_parse_callchain_opt.

I can modify builtin-top.c's defintion to top_parse_callchain_opt, but do
we want to make the function parse_callchain_opt name more obvious that it is
for 'report' style parsing (which means it looks for the embedded
callchain flag)?  Vs. the record_parse_callchain_opt function, which is for
setting up the callchain flag?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/