Re: [PATCH] clk: Add driver for Palmas clk32kg and clk32kgaudio clocks

From: Nishanth Menon
Date: Thu Apr 03 2014 - 09:49:56 EST


On 04/03/2014 05:52 AM, Peter Ujfalusi wrote:
[...]
> .../devicetree/bindings/clock/clk-palmas.txt | 35 +++
> drivers/clk/Kconfig | 7 +
> drivers/clk/Makefile | 1 +
> drivers/clk/clk-palmas.c | 307 +++++++++++++++++++++
> include/dt-bindings/mfd/palmas.h | 18 ++
> 5 files changed, 368 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/clk-palmas.txt
> create mode 100644 drivers/clk/clk-palmas.c
> create mode 100644 include/dt-bindings/mfd/palmas.h


Only complaint i have is based on :
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=2a9330010bea5982a5c6593824bc036bf62d67b7

you may want to split the new binding off to a separate patch.
Otherwise, personally, I think it is an good evolution, thanks for
doing it.


--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/