Re: [PATCH] ASoC: dapm: Add support for multi register mux

From: Mark Brown
Date: Thu Apr 03 2014 - 05:54:02 EST


On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:

> I'm a bit late in the game, but I feel a bit uneasy through looking
> at the whole changes. My primary question is, whether do we really
> need to share the same struct soc_enum for the onehot type? What
> makes hard to use a struct soc_enum_onehot for them? You need
> different individual get/put for each type. We may still need to
> change soc_dapm_update stuff, but it's different from sharing
> soc_enum.

Indeed, I had thought this was where the discussion was heading - not
looked at this version of the patch yet.

Attachment: signature.asc
Description: Digital signature