RE: [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c

From: Jayamohan Kallickal
Date: Thu Apr 03 2014 - 01:03:26 EST


Looks good

Acked-by: Jayamohan Kallickal <Jayamohan.Kallickal@xxxxxxxxxx>
---

-----Original Message-----
From: Rashika Kheria [mailto:rashika.kheria@xxxxxxxxx]
Sent: Saturday, March 29, 2014 10:44 AM
To: linux-kernel@xxxxxxxxxxxxxxx
Cc: Jayamohan Kallickal; James E.J. Bottomley; linux-scsi@xxxxxxxxxxxxxxx; josh@xxxxxxxxxxxxxxxx
Subject: [PATCH 02/55] scsi: Mark function as static in be2iscsi/be_cmds.c

Mark function as static in be2iscsi/be_cmds.c because it is not used outside this file.

This eliminates the following warning in be2iscsi/be_cmds.c:
drivers/scsi/be2iscsi/be_cmds.c:401:5: warning: no previous prototype for âbeiscsi_process_mccâ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@xxxxxxxxx>
Reviewed-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
---
drivers/scsi/be2iscsi/be_cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..026c3e3 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -398,7 +398,7 @@ static void beiscsi_cq_notify(struct beiscsi_hba *phba, u16 qid, bool arm, }


-int beiscsi_process_mcc(struct beiscsi_hba *phba)
+static int beiscsi_process_mcc(struct beiscsi_hba *phba)
{
struct be_mcc_compl *compl;
int num = 0, status = 0;
--
1.7.9.5