Re: [PATCH] integrity: get comm using lock to avoid race in string printing

From: Steve Grubb
Date: Wed Apr 02 2014 - 14:01:04 EST


Hello Mimi,

On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote:
> This change is already being upstreamed as commit 73a6b44 "Integrity:
> Pass commname via get_task_comm()".

While I was looking at Richard's patch, I noticed a few places where cause and
op are logged and the string isn't tied together with a _ or -. These are in
ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are
these fixed upstream? Or should a patch be made?

Thanks,
-Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/