Re: [PATCH 2/2] ttyprintk: Allow built as a module

From: Takashi Iwai
Date: Wed Apr 02 2014 - 08:42:19 EST


At Wed, 02 Apr 2014 14:31:46 +0200,
Jean Delvare wrote:
>
> Hi Takashi,
>
> Le Wednesday 02 April 2014 Ã 12:29 +0200, Takashi Iwai a Ãcrit :
> > The driver is well written to be used as a module, just the exit call
> > is missing.
> >
> > Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> > ---
> > drivers/char/Kconfig | 2 +-
> > drivers/char/ttyprintk.c | 13 ++++++++++++-
> > 2 files changed, 13 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> > index 1386749b48ff..97816b133c7f 100644
> > --- a/drivers/char/Kconfig
> > +++ b/drivers/char/Kconfig
> > @@ -40,7 +40,7 @@ config SGI_MBCS
> > source "drivers/tty/serial/Kconfig"
> >
> > config TTY_PRINTK
> > - bool "TTY driver to output user messages via printk"
> > + tristate "TTY driver to output user messages via printk"
> > depends on EXPERT && TTY
> > default n
> > ---help---
> > diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
> > index 2a39c5790364..73606eaaba71 100644
> > --- a/drivers/char/ttyprintk.c
> > +++ b/drivers/char/ttyprintk.c
> > @@ -17,7 +17,7 @@
> > #include <linux/device.h>
> > #include <linux/serial.h>
> > #include <linux/tty.h>
> > -#include <linux/export.h>
> > +#include <linux/module.h>
> >
> > struct ttyprintk_port {
> > struct tty_port port;
> > @@ -214,4 +214,15 @@ error:
> > tty_port_destroy(&tpk_port.port);
> > return ret;
> > }
> > +
> > +static void ttyprintk_exit(void)
>
> Could be marked __exit.
>
> > +{
> > + tty_unregister_driver(ttyprintk_driver);
> > + put_tty_driver(ttyprintk_driver);
> > + tty_port_destroy(&tpk_port.port);
> > +}
> > +
> > device_initcall(ttyprintk_init);
> > +module_exit(ttyprintk_exit);
> > +
> > +MODULE_LICENSE("GPL");
>
> Other than this, this looks good, thanks for doing that.
>
> Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Thanks! I'll resubmit the fixed patch.


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/