Re: [v2 PATCH 1/1] fs/mpage.c: forgotten WRITE_SYNC in case of WB_SYNC_ALL

From: Andrew Morton
Date: Tue Apr 01 2014 - 16:50:38 EST


On Sat, 15 Mar 2014 00:34:28 +0900 Roman Pen <r.peniaev@xxxxxxxxx> wrote:

> When data integrity operation happens (sync, fsync, fdatasync calls)
> writeback control is set to WB_SYNC_ALL. In that case all write
> requests are marked with WRITE_SYNC (WRITE | REQ_SYNC | REQ_NOIDLE)
> indicating that caller is waiting for completion and block layer or
> block device should prioritize the IO avoiding any possible delays.
>
> But mpage writeback path ignores marking requests as WRITE_SYNC.
>
> This patch fixes this.

Sorry, but it would be unwise to merge this without a good
understanding of its runtime effects.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/