Re: [PATCH] ARM: dts: exynos5250: turn on the LDO10 on SMDK5250

From: Tomasz Figa
Date: Fri Mar 14 2014 - 13:18:49 EST


Hi Yuvaraj,

On 14.03.2014 09:26, Yuvaraj Kumar wrote:
Any comments on this?

On Mon, Mar 3, 2014 at 4:45 PM, Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxx> wrote:
Commit 275dcd2 "ARM: dts: add max77686 pmic node for smdk5250" added
required LDO's for SMDK5250 boards.Currently LDO10 is turned off.As LDO10,
enable/disable the LDO22 which is required for VDDQ_MMC2_AP.So this patch
makes LDO10 turn's on always.

This does not seem right to me. Why a regulator used by MMC should be always enabled? Shouldn't it be specified as one of the MMC regulators in corresponding MMC controller node?

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/