Re: [tip:perf/core] ARM64, perf: Add support for perf registers API

From: Catalin Marinas
Date: Thu Mar 13 2014 - 07:36:15 EST


On Thu, Mar 13, 2014 at 11:01:21AM +0000, Ingo Molnar wrote:
> * Catalin Marinas <catalin.marinas@xxxxxxx> wrote:
> > On Thu, Mar 13, 2014 at 12:27:45AM -0700, tip-bot for Jean Pihet wrote:
> > > Commit-ID: 1acfb01a43db9d8cde2d4c1d51746bae0b46b06b
> > > Gitweb: http://git.kernel.org/tip/1acfb01a43db9d8cde2d4c1d51746bae0b46b06b
> > > Author: Jean Pihet <jean.pihet@xxxxxxxxxx>
> > > AuthorDate: Mon, 3 Feb 2014 19:18:27 +0100
> > > Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> > > CommitDate: Wed, 12 Mar 2014 13:45:28 +0100
> > >
> > > ARM64, perf: Add support for perf registers API
> > >
> > > This patch implements the functions required for the perf
> > > registers API, allowing the perf tool to interface kernel
> > > register dumps with libunwind in order to provide userspace
> > > backtracing. Compat mode is also supported.
> > >
> > > Only the general purpose user space registers are exported,
> > > i.e.: PERF_REG_ARM_X0,
> > > ...
> > > PERF_REG_ARM_X28,
> > > PERF_REG_ARM_FP,
> > > PERF_REG_ARM_LR,
> > > PERF_REG_ARM_SP,
> > > PERF_REG_ARM_PC
> > > and not the PERF_REG_ARM_V* registers.
> > >
> > > Signed-off-by: Jean Pihet <jean.pihet@xxxxxxxxxx>
> > > Acked-by: Will Deacon <will.deacon@xxxxxxx>
> > > Cc: Arnaldo <acme@xxxxxxxxxxxxxxxxxx>
> > > Cc: Jiri Olsa <jolsa@xxxxxxxxxx>
> > > Cc: patches@xxxxxxxxxx
> > > Cc: linaro-kernel@xxxxxxxxxxxxxxxx
> > > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > > Link: http://lkml.kernel.org/r/1391451509-31265-2-git-send-email-jean.pihet@xxxxxxxxxx
> > > Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> > > ---
> > > arch/arm64/Kconfig | 2 ++
> > > arch/arm64/include/asm/ptrace.h | 1 +
> > > arch/arm64/include/uapi/asm/Kbuild | 1 +
> > > arch/arm64/include/uapi/asm/perf_regs.h | 40 ++++++++++++++++++++++++++++++
> > > arch/arm64/kernel/Makefile | 1 +
> > > arch/arm64/kernel/perf_regs.c | 44 +++++++++++++++++++++++++++++++++
> > > 6 files changed, 89 insertions(+)
> >
> > As I replied to Jean yesterday, I merged the arch/arm64 patches already
> > in the arm64 tree. Is it late to drop them from tip (and avoid potential
> > conflicts)?
> >
> > But please take the perf tools patch (tools/perf/arch/arm64/...).
>
> Well, I merged them so that the tooling bits can be tested on top of
> that and merged as well.

That's why I asked if I should take the tooling bits but Will objected ;).

> Anyway, I dropped them, they were still the tail of tip:perf/core.

Thanks. I assume you still take the tooling patch?

--
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/