Re: [PATCH V7 1/1] drivers/gpio: Altera soft IP GPIO driver and devicetree binding

From: Linus Walleij
Date: Wed Mar 12 2014 - 10:52:24 EST


On Sat, Mar 8, 2014 at 12:50 PM, Gerhard Sittig <gsi@xxxxxxx> wrote:
> On Fri, Mar 07, 2014 at 11:31 +0800, Linus Walleij wrote:
>>
>> On Mon, Mar 3, 2014 at 6:27 PM, <thloh@xxxxxxxxxx> wrote:
>>
>> > From: Tien Hock Loh <thloh@xxxxxxxxxx>
>> >
>> > Add driver support for Altera GPIO soft IP, including interrupts and I/O.
>> > Tested on Altera CV SoC board using dipsw and LED using LED framework.
>> >
>> > Signed-off-by: Tien Hock Loh <thloh@xxxxxxxxxx>
>>
>> Can I get some ACKs on this? Like from Gerhard, DT folks?
>>
>> Or is there still more things to do?
>
> Sorry, had flagged the patch for review, but did not get around
> to respond earlier. No ACK from me for v7 as it is.

OK I'm holding this back.

> Am I supposed to provide ACKs at all, given that I'm a reviewer
> and fellow developer. I always understood that Acked-By is
> something more formal, where one maintainer signals to another
> maintainer that it's OK to go though a different tree.

In this case I want an Acked-by/Reviewed-by tag (choose!)
beacuse I trust your ability to review this specific code, as simple as
that. :-)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/