Re: [PATCH 1/3] dt-bindings: document gpio-charger bindings

From: Rob Herring
Date: Wed Mar 12 2014 - 10:28:56 EST


On Wed, Mar 12, 2014 at 8:46 AM, Heiko Stübner <heiko@xxxxxxxxx> wrote:
> From: Heiko Stuebner <heiko.stuebner@xxxxxx>
>
> This documents the binding for the gpio-charger power-supply.

How does this relate to what's documented in power_supply.txt and
charger-manager.txt? Both have references to USB charging. Doesn't
this need some connection to a battery node?

Rob

>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@xxxxxx>
> ---
> .../bindings/power_supply/gpio-charger.txt | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power_supply/gpio-charger.txt
>
> diff --git a/Documentation/devicetree/bindings/power_supply/gpio-charger.txt b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
> new file mode 100644
> index 0000000..fad87a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power_supply/gpio-charger.txt
> @@ -0,0 +1,23 @@
> +gpio-charger
> +
> +Required properties :
> + - compatible : "gpio-charger"
> + - gpios : GPIO indicating the charger presence.
> + See GPIO binding in bindings/gpio/gpio.txt .
> + - charger-type : power supply type, one of
> + unknown
> + battery
> + ups
> + mains
> + usb-sdp (USB standard downstream port)
> + usb-dcp (USB dedicated charging port)
> + usb-cdp (USB charging downstream port)
> + usb-aca (USB accessory charger adapter)
> +
> +Example:
> +
> + charger {
> + compatible = "gpio-charger";
> + charger-type = "usb-sdp";
> + gpios = <&gpf0 2 0 0 0>;
> + }
> --
> 1.8.5.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/