Re: [PATCH] cpuidle: add 'failed' statistic

From: Daniel Lezcano
Date: Tue Mar 11 2014 - 17:52:56 EST


On 03/11/2014 03:00 AM, Len Brown wrote:
Exactly what use-case do you have in mind for this attribute?

Nothing more than balance the c-state usage with the selection efficiency of this state. The current statistics do not give a lot of clues of what is happening.

"failed" is a strong word.
Some validation guy is going to send me e-mail when it is non-zero...
I don't like that use-case.

But even if re-named, I don't see see how it will be useful.
When I want to see how C-state predictions are doing, I use ftrace,
which can show me the actual expected and actual times, not just a count
of how man times predicted was < actual.

Mmh, where do you retrieve the target_residency from userspace ? This information is not exported from ftrace neither sysfs.

I would rather see some good tracepoints go upstream.

Ok, which tracepoints you would like to see ?

target residency=%lu, expected residency=%lu, measured residency=%lu

??

Thanks
-- Daniel


--
<http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/